Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39377: json: Remove encoding option. #18075

Merged
merged 2 commits into from
Jan 20, 2020
Merged

bpo-39377: json: Remove encoding option. #18075

merged 2 commits into from
Jan 20, 2020

Conversation

methane
Copy link
Member

@methane methane commented Jan 20, 2020 •
edited
Loading

@methane @ammaraskar
Update Misc/NEWS.d/next/Library/2020-01-20-13-00-35.bpo-39377.QSFdaU.rst
605b23a 
Co-Authored-By: Ammar Askar <ammar_askar@hotmail.com>
@methane methane merged commit 5492bfc into python:master Jan 20, 2020
@methane methane deleted the remove-json-encoding branch January 20, 2020 04:54
sthagen added a commit to sthagen/python-cpython that referenced this pull request Jan 20, 2020
@sthagen
Merge pull request #193 from python/master
ee4c047 
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
@ammaraskar
Copy link
Member

Oh sorry, I missed that there was a mention of encoding in https://github.com/python/cpython/blob/master/Doc/library/json.rst on line 286:

The other arguments have the same meaning as in :func:load, except
encoding which is ignored and deprecated since Python 3.1.

Should this be removed as well?

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@methane @shihai1991
bpo-39377: json: Remove the encoding option. (pythonGH-18075)
1365a52
This was referenced Jul 16, 2020
Open
Closed
Closed
@tirkarthi tirkarthi mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @ammaraskar @the-knights-who-say-ni @bedevere-bot