Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-38410: Properly handle PySys_Audit() failures #18658

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 25, 2020

_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter()
didn't include proper error handling for their PySys_Audit() calls.

Co-authored-by: Zackery Spytz zspytz@gmail.com

https://bugs.python.org/issue38410

_PyEval_SetAsyncGenFinalizer() and _PyEval_SetAsyncGenFirstiter()
didn't include proper error handling for their PySys_Audit() calls.

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #18658 into 3.8 will increase coverage by 2.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              3.8   #18658       +/-   ##
===========================================
+ Coverage   79.13%   82.10%    +2.96%     
===========================================
  Files         381     1918     +1537     
  Lines      172572   576877   +404305     
  Branches        0    43736    +43736     
===========================================
+ Hits       136562   473624   +337062     
- Misses      36010    93684    +57674     
- Partials        0     9569     +9569     
Impacted Files Coverage Δ
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Modules/clinic/spwdmodule.c.h 58.33% <0.00%> (-3.21%) ⬇️
Modules/clinic/resource.c.h 78.57% <0.00%> (-2.68%) ⬇️
Modules/clinic/_pickle.c.h 62.40% <0.00%> (-2.33%) ⬇️
Modules/clinic/signalmodule.c.h 71.51% <0.00%> (-2.32%) ⬇️
Python/clinic/marshal.c.h 77.77% <0.00%> (-2.23%) ⬇️
Modules/clinic/_weakref.c.h 77.77% <0.00%> (-2.23%) ⬇️
Modules/clinic/_queuemodule.c.h 78.08% <0.00%> (-2.17%) ⬇️
Modules/_multiprocessing/clinic/posixshmem.c.h 66.66% <0.00%> (-2.09%) ⬇️
Objects/clinic/moduleobject.c.h 78.94% <0.00%> (-2.01%) ⬇️
... and 1804 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4a3df...926440b. Read the comment docs.

@serhiy-storchaka serhiy-storchaka merged commit 87a4cd5 into python:3.8 Mar 2, 2020
@serhiy-storchaka serhiy-storchaka deleted the bpo-38410-PySys_Audit-failures-3.8 branch March 2, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants