Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39816: More descriptive error msg than "too many values to unpack" #19036

Closed

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Mar 17, 2020

@ZackerySpytz
Copy link
Contributor Author

If this approach is accepted, this PR would still need a news entry.

@aeros
Copy link
Contributor

aeros commented May 28, 2020

@csabella It looks like this PR is still in the draft stage, which typically is used by the author to indicate that it's not quite ready for review yet. Assuming @ZackerySpytz marks it as "Ready for Review" at some point, I'll try to look it over when I get the chance.

@rhettinger
Copy link
Contributor

I don't think this should be done. It tightly couples the input side with the actual unpacking. Also, the message "too many value to unpack" is clear enough. I teach this to a new group of students every week and there is never a misunderstanding.

Marking this a closed. If someone wants to champion this, feel free to reopen. My opinion is that it isn't good design and that there isn't a real problem being solved.

@rhettinger rhettinger closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants