bpo-40038: pathlib: remove partial support for preserving accessor when modifying a path #19342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you merge / rebase with git master so that we run CI freshly? |
barneygale
force-pushed
the
bpo-40038-pathlib-path-private-init
branch
from
71e433a
to
b65d1cc
Compare
|
Rebased. Sorry for long delay. |
…en modifying a path
barneygale
force-pushed
the
bpo-40038-pathlib-path-private-init
branch
from
b65d1cc
to
ad0ebef
Compare
|
@pitrou this is read for review FYI! Thanks very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now #18846 has landed,
pathlib.Path._init()does nothing useful and can be removed.A long time ago,
_init()helped preserve the current accessor when creating new paths from an existing path (e.g. by callingq = p.resolve()). But this has only ever worked for a small handful of methods, was never documented, and we currently don't support anything other than_NormalAccessoranyway.More info in the bug report.
https://bugs.python.org/issue40038