-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40208: Remove deprecated has_exec method of SymbolTable #19396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update Doc/library/symtable.rst also :)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Thanks for the reminder. I have made the requested changes; please review again |
Thanks for making the requested changes! @corona10: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I 've also checked @gvanrossum and @terryjreedy 's comment.
It looks like safe to remove :)
Thanks for catching this!
cc @vstinner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor change. Will merge after tests pass again.
Corona10 war referring to comments on issue, in particular, Guido's approval.
@corona10 Since you did initial review, go ahead and merge and close issue if you want. I will wait until my tomorrow. |
Thanks :) Since I am in post-promotion mentoring period, Thank you for understanding :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @corona10: You can merge it.
https://bugs.python.org/issue40208