-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40334: refactor and cleanup for the PEG generators #19775
Conversation
8542748
to
be64838
Compare
be64838
to
61cd349
Compare
😃 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really a great improvement! Thanks a a lot! Most of my comments are stylistic, so feel free to ignore them.
Co-Authored-By: Lysandros Nikolaou <lisandrosnik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🚀
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The buildbot failures are unrelated and they are being addressed here: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for this one too! |
Improvements in this PR:
visiting: now the code has a local variable scope with a context manager.
more explicit and carrying metadata if needed. Also helps when debugging (from experience 😉 ).
add_var
the variabletype
could actually have beenNone
as opposed to our previous declaration).https://bugs.python.org/issue40334