bpo-40839: PyDict_GetItem() requires the GIL #20580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @methane |
methane
reviewed
Jun 2, 2020
methane
reviewed
Jun 2, 2020
methane
approved these changes
Jun 2, 2020
Calling PyDict_GetItem() without GIL held had been allowed for historical reason. It is no longer allowed.
|
Thanks for the review @methane! I replaced your documentation my mine in all places ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyDict_GetItem() must now be called with the GIL held.
https://bugs.python.org/issue40839