-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) #20980
Conversation
Without yet looking at the code, I can verify that this PR fixes the stderr noise on the RHEL8 FIPS enabled builbot and also clears the warning: Warning -- logging._handlerList was modified by test_hashlib Also minor typo: s/hashses/hashes |
Relevant buildbot: https://buildbot.python.org/all/#/builders/764/builds/150 |
Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <christian@python.org>
a5e11d5
to
0866ed3
Compare
I have been asked to review this change. Honestly, I don't feel able to review this PR. I tried but failed to understand the complexity of hashlib build options and FIPS mode. If you are confident and @stratakis confirms that this change fix his issue, just merge your PR. |
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
…-20980) Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 975022b) Co-authored-by: Christian Heimes <christian@python.org>
GH-23343 is a backport of this pull request to the 3.9 branch. |
Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <christian@python.org> (cherry picked from commit 975022b) Co-authored-by: Christian Heimes <christian@python.org>
…-20980) Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <christian@python.org>
Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40637