bpo-41137: Use utf-8 encoding while reading .pdbrc files #21263
Conversation
|
Thank you for your PR @srinivasreddy, but it needs more changes:
|
|
@serhiy-storchaka Not sure why windows build is failing. Any idea why? |
Lib/test/test_pdb.py
Outdated
| try: | ||
| with support.temp_cwd(): | ||
| with open('.pdbrc', 'w') as f: | ||
| f.write("Fran\u00E7ais\n") |
There was a problem hiding this comment.
It will not work on locales with encoding which does not allow to encode \u00E7. You need to find characters which are encodable with the locale encoding.
Also, it would be better to use more realistic example. Use a command which takes a non-ASCII argument and check that it works correctly.
There was a problem hiding this comment.
Now the build is passing. And I would like to keep this negative test case as it would, in utf-8 encoding gives "NameError: name 'Française' is not defined". Or do you still want me write the test you commented above?
| @@ -1448,6 +1447,40 @@ def test_readrc_homedir(self): | |||
| if save_home is not None: | |||
| os.environ["HOME"] = save_home | |||
|
|
|||
| def test_read_pdbrc_with_ascii_encoding(self): | |||
There was a problem hiding this comment.
I am not sure this test case is worth enough.
…es with 'utf-8' encoding
…ise' to .pdbrc file and try to read the file with ascii encoding. And test the read failure in stderr
https://bugs.python.org/issue41137