Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407

Merged
merged 1 commit into from
Jul 9, 2020
Merged

bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407

merged 1 commit into from
Jul 9, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 9, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue41252

Automerge-Triggered-By: @tiran

@ZackerySpytz ZackerySpytz requested a review from tiran as a code owner July 9, 2020 03:56
@tiran tiran added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Jul 9, 2020
tiran
tiran approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@miss-islington miss-islington merged commit ee96f32 into python:master Jul 9, 2020
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@ZackerySpytz @miss-islington
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
a354818 
…() (pythonGH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 9, 2020
@bedevere-bot
Copy link

GH-21410 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jul 9, 2020
@bedevere-bot
Copy link

GH-21411 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2020
@ZackerySpytz @miss-islington
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
89a9263 
…() (pythonGH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 9, 2020
@miss-islington @ZackerySpytz
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
54babbe 
…() (GH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 9, 2020
@miss-islington @ZackerySpytz
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
90584c0 
…() (GH-21407)

(cherry picked from commit ee96f32)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@ZackerySpytz @arun-mani-j
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
69c7174 
…() (pythonGH-21407)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@ZackerySpytz @shihai1991
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback…
e8e8414 
…() (pythonGH-21407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni