Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41624: fix documentation of typing.Coroutine #21952

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

Elaphurus
Copy link
Contributor

@Elaphurus Elaphurus commented Aug 25, 2020

The documentation [1] for Coroutine in typing library writes:

class typing.Coroutine(Awaitable[V_co], Generic[T_co T_contra, V_co])

which should be:

class typing.Coroutine(Awaitable[V_co], Generic[T_co, T_contra, V_co])

a comma is missed between the first type variable T_co and the second one T_contr.

[1] https://docs.python.org/3/library/typing.html#typing.Coroutine

https://bugs.python.org/issue41624

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Elaphurus

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 25, 2020
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. News entry is not needed. I will add skip-news label.

@ambv ambv merged commit 8c58d2a into python:master Aug 27, 2020
@Elaphurus Elaphurus deleted the fix-issue-41624 branch August 27, 2020 01:49
@tirkarthi tirkarthi added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Aug 27, 2020
@miss-islington
Copy link
Contributor

Thanks @Elaphurus for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @Elaphurus for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @Elaphurus and @ambv, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8c58d2a216ca2b5965361df9b8d8944bc7d4854d 3.8

@miss-islington
Copy link
Contributor

Sorry @Elaphurus and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8c58d2a216ca2b5965361df9b8d8944bc7d4854d 3.9

tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Aug 27, 2020
(cherry picked from commit 8c58d2a)

Co-authored-by: MingZhe Hu <humingzhework@163.com>
@bedevere-bot
Copy link

GH-21982 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 27, 2020
tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Aug 27, 2020
(cherry picked from commit 8c58d2a)

Co-authored-by: MingZhe Hu <humingzhework@163.com>
@bedevere-bot
Copy link

GH-21983 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Aug 27, 2020
gvanrossum pushed a commit that referenced this pull request Aug 28, 2020
…21983)

(cherry picked from commit 8c58d2a)

Co-authored-by: MingZhe Hu <humingzhework@163.com>

Co-authored-by: MingZhe Hu <humingzhework@163.com>
gvanrossum pushed a commit that referenced this pull request Aug 28, 2020
…1982)

(cherry picked from commit 8c58d2a)

Co-authored-by: MingZhe Hu <humingzhework@163.com>

Co-authored-by: MingZhe Hu <humingzhework@163.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants