Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-23706: Add newline parameter to pathlib.Path.write_text (GH-22420) #22420

Merged
merged 6 commits into from
Oct 21, 2020

Conversation

skilaren
Copy link
Contributor

@skilaren skilaren commented Sep 26, 2020

  • Add newline parameter to pathlib.Path.write_text()
  • Update documentation of pathlib.Path.write_text()
  • Add test case for pathlib.Path.write_text() calls with newline parameter passed

https://bugs.python.org/issue23706

Automerge-Triggered-By: GH:methane

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@skilaren

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@skilaren skilaren changed the title bpo-23706: Add newline parameter to pathlib.Path.write_text method (GH-NNNN) bpo-23706: Add newline parameter to pathlib.Path.write_text method (GH-22420) Sep 26, 2020
Lib/pathlib.py Outdated Show resolved Hide resolved
Copy link
Contributor

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should need a news entry in Misc/NEWS.d/next/Library. See blurb or blurb-it for more information.

@methane methane changed the title bpo-23706: Add newline parameter to pathlib.Path.write_text method (GH-22420) bpo-23706: Add newline parameter to pathlib.Path.write_text (GH-22420) Oct 21, 2020
@miss-islington
Copy link
Contributor

@skilaren: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 5f22741 into python:master Oct 21, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…-22420) (pythonGH-22420)

* Add _newline_ parameter to `pathlib.Path.write_text()`
* Update documentation of `pathlib.Path.write_text()`
* Add test case for `pathlib.Path.write_text()` calls with _newline_ parameter passed

Automerge-Triggered-By: GH:methane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants