bpo-38323: Add guard clauses in MultiLoopChildWatcher. #22756
Conversation
This is a trivial refactor in preparation for a fix for bpo-38323.
There was a problem hiding this comment.
LGTM. Sorry for the delay, I got caught up with organizing the sprint (and participating the week of Oct. 19-23), then took a bit of a break after it was over.
With usage of guard clauses instead of an additional layer of nested indents though, I found it significantly easier to mentally parse (which makes a difference especially for someone less experienced w/ non-trivial signal handling, like myself). Also, thanks for splitting this refactor away from #20142, that definitely makes the review process easier.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
asvetlov
added
needs backport to 3.8
|
Thanks @cjerdonek for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
@asvetlov: Please replace |
|
Thanks! Sorry for delay |
|
GH-23806 is a backport of this pull request to the 3.9 branch. |
This is a trivial refactor in preparation for a fix for bpo-38323. (cherry picked from commit 66d3b58) Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
This is a trivial refactor in preparation for a fix for bpo-38323. (cherry picked from commit 66d3b58) Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
|
GH-23807 is a backport of this pull request to the 3.8 branch. |
This is a trivial refactor in preparation for a fix for bpo-38323.
This is a trivial refactor in preparation for a fix for bpo-38323 (see #20142).
https://bugs.python.org/issue38323