[3.8] bpo-35181: Correct importlib documentation for some module attributes (GH-15190) #22873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-15190) @ericsnowcurrently This PR will change the following: In the library documentation importlib.rst: - `module.__package__` can be `module.__name__` for packages; - `spec.parent` can be `spec.__name__` for packages; - `spec.loader` is not `None` for namespaces packages. In the language documentation import.rst: - `spec.loader` is not `None` for namespace packages. Automerge-Triggered-By: GH:warsaw (cherry picked from commit 27f1bd8) Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
warsaw
approved these changes
Oct 21, 2020
|
@maggyero: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ericsnowcurrently This PR will change the following:
In the library documentation importlib.rst:
module.__package__can bemodule.__name__for packages;spec.parentcan bespec.__name__for packages;spec.loaderis notNonefor namespaces packages.In the language documentation import.rst:
spec.loaderis notNonefor namespace packages.Automerge-Triggered-By: GH:warsaw
(cherry picked from commit 27f1bd8)
Co-authored-by: Géry Ogam gery.ogam@gmail.com
https://bugs.python.org/issue35181
Automerge-Triggered-By: GH:warsaw