Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42197: Disable automatic update of frame locals during tracing #23028

Closed
wants to merge 1 commit into from

Conversation

fabioz
Copy link
Contributor

@fabioz fabioz commented Oct 29, 2020

This pull request removes the calls to PyFrame_FastToLocalsWithError and PyFrame_LocalsToFast inside the tracing.

https://bugs.python.org/issue42197

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@fabioz

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@fabioz
Copy link
Contributor Author

fabioz commented Dec 20, 2020

@vstinner updated docs with requested changes.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 21, 2020
@vstinner
Copy link
Member

cc @markshannon @ncoghlan

@markshannon
Copy link
Member

@fabioz could you update this for 3.11?

@markshannon
Copy link
Member

@fabioz If you don't have time to do this, just say and I'll put together a new PR.

@fabioz
Copy link
Contributor Author

fabioz commented Feb 5, 2022

@fabioz If you don't have time to do this, just say and I'll put together a new PR.

Hello @markshannon I really have my hands full right now, so, if you can put together a new PR that'd be great.

@markshannon
Copy link
Member

New PR is #32055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants