bpo-30723: Enhancement to IDLE parenmatch extension #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added highlight both parens option.
|
@wohlganger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @Yhg1s to be potential reviewers. |
wohlganger
changed the title
|
I think this changed isn't trivial, you will need to first add the issue on bugs.python.org. Nosy @terryjreedy for this is a IDLE PR. |
|
Added to bugs.python.org . ID# 30723 |
terryjreedy
changed the title
|
Minor change committed to fix conflict with bpo-29910. |
terryjreedy
requested changes
Jun 27, 2017
There was a problem hiding this comment.
I made comments about the initial PR on bpo-30723 and made desired changes myself. Still need news.
terryjreedy
approved these changes
Jun 27, 2017
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 28, 2017
…lp (pythonGH-2306) * Add 'parens' style to highlight both opener and closer. * Make 'default' style, which is not default, a synonym for 'opener'. * Make time-delay work the same with all styles. * Add help for config dialog extensions tab, including parenmatch. * Add new tests. Original patch by Charles Wohlganger. (cherry picked from commit fae2c35)
terryjreedy
added a commit
that referenced
this pull request
Jun 28, 2017
…lp (GH-2306) (#2460) * Add 'parens' style to highlight both opener and closer. * Make 'default' style, which is not default, a synonym for 'opener'. * Make time-delay work the same with all styles. * Add help for config dialog extensions tab, including parenmatch. * Add new tests. Original patch by Charles Wohlganger. (cherry picked from commit fae2c35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added highlight both parens option.
added name to acks file.