New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35728: Add root parameter to tkinter.font.nametofont() #23885
bpo-35728: Add root parameter to tkinter.font.nametofont() #23885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is not terribly useful, but now is consistent with other functions. Tests look good. Thanks..
Doc/library/tkinter.font.rst
Outdated
Return a :class:`Font` representation of a tk named font. | ||
|
||
.. versionchanged:: 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be missing a space here, indentation in rST is 3 spaces. On some versions of sphinx this causes visual differences.
.. versionchanged:: 3.10 | |
.. versionchanged:: 3.10 | |
Added the *root* keyword argument. |
Other than that, LGTM :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! I've updated the documentation accordingly
Both Travis and Pipelines failed the doc check of the news item, which I believe is unchanged from the previous run that passed. I don't understand the complaint or know if the test was changed. I restarted Travis and now it passes. Maybe the transient failure was in github. I don't see any way to rerun Pipelines, but since it is the same test, and it passes before, I would consider ignoring it.
|
The error means that another news item in another bpo used single backticks rather than double backticks for styling code. The news item was recently fixed in 8badade. Pulling in the latest changes from master into this PR will fix it. |
Messages crossed. @desmondcheongzx please do the update with fetch and merge (or simple pull) rather than with 'force' argument, as some mistakenly do. It is too easy to mess up PR with the latter. |
…t-parameter-to-tkinter-font-nametofont
Got it, I've made the appropriate update. |
Thank you for your contribution @desmondcheongzx! |
Thank you for the reviews! |
Add a root parameter to tkinter.font.nametofont() so that the function can be called even when default root is disabled.
https://bugs.python.org/issue35728
https://bugs.python.org/issue35728