bpo-33809: add the TracebackException.print() method #24231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
iritkatriel
changed the title
iritkatriel
changed the title
iritkatriel
changed the title
iritkatriel
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4abf619 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
terryjreedy
requested changes
May 22, 2021
There was a problem hiding this comment.
Approved after adding default to doc. And when you do, no re-review needed ;-).
The PR factors print code out of print_exception and moves it to the class so it can be used with any class instance, however created. I agree with this solution to the bpo request.
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
Thanks @terryjreedy ! |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
|
I know you said no need for re-review, but I'm trying to keep the bot happy. |
terryjreedy
approved these changes
May 22, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the content of the module-level traceback.print_exception() into a new print() method on TracebackException so that people can do
TracebackException(exc, various configuration options ... ).print()
https://bugs.python.org/issue33809