Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43207: InspectLoader.is_package is not an abstract method #24517

Merged
merged 1 commit into from
May 23, 2021

Conversation

Isa-rentacs
Copy link
Contributor

@Isa-rentacs Isa-rentacs commented Feb 12, 2021

Making the description of InspectLoader.is_package aligned with the current implementation.

https://bugs.python.org/issue43207

Automerge-Triggered-By: GH:jaraco

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Isa-rentacs

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 21, 2021
@Isa-rentacs
Copy link
Contributor Author

@FFY00 Thank you for your approval, could you teach me what else is needed to push through this change?

@FFY00
Copy link
Member

FFY00 commented May 22, 2021

We need a core dev to merge this, and that is often hard as there is too much to do and too little time 😅

@jaraco would you be able to take a look when you have a moment?
This is a pretty straightforward fix, is_package used to be an abstract method, a concrete implementation was provided and the method bumped down to optional, but the documentation text was not updated.

@jaraco jaraco added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed needs backport to 3.8 only security fixes labels May 23, 2021
@jaraco
Copy link
Member

jaraco commented May 23, 2021

Looking at the report, this issue has been around since Python 3.4, so I'm backporting it to all Pythons receiving bug fixes.

@miss-islington
Copy link
Contributor

Thanks @Isa-rentacs for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2021
…GH-24517)

Making the description of `InspectLoader.is_package` aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda <Isa-rentacs@users.noreply.github.com>
@bedevere-bot
Copy link

GH-26321 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 23, 2021
@bedevere-bot
Copy link

GH-26322 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 23, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2021
…GH-24517)

Making the description of `InspectLoader.is_package` aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda <Isa-rentacs@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 23, 2021
Making the description of `InspectLoader.is_package` aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda <Isa-rentacs@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Jul 12, 2021
…) (#26322)

Making the description of `InspectLoader.is_package` aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda <Isa-rentacs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants