Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43277: Add PySet_CheckExact to the C-API #24598

Merged
merged 2 commits into from
Feb 20, 2021
Merged

bpo-43277: Add PySet_CheckExact to the C-API #24598

merged 2 commits into from
Feb 20, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 20, 2021 •
edited
Loading

For some mysterious reason we have PySet_Check, PyFrozenSet_Check, PyAnySet_Check, PyAnySet_CheckExact and PyFrozenSet_CheckExact but no PySet_CheckExact

Automerge-Triggered-By: GH:pablogsal

vstinner
vstinner approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just left a minor comment :-p

Include/setobject.h Outdated Show resolved Hide resolved
@pablogsal @vstinner
Update Include/setobject.h
35fe249 
Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a failure ❌ .

@pablogsal pablogsal merged commit d439fb3 into python:master Feb 20, 2021
@pablogsal pablogsal mentioned this pull request Feb 20, 2021
Merged
sthagen added a commit to sthagen/python-cpython that referenced this pull request Feb 20, 2021
@sthagen
Merge pull request #394 from python/master
912dbe2 
bpo-43277: Add PySet_CheckExact to the C-API (pythonGH-24598)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-43277: Add PySet_CheckExact to the C-API (pythonGH-24598)
e71b771 
For some mysterious reason we have PySet_Check, PyFrozenSet_Check, PyAnySet_Check, PyAnySet_CheckExact and PyFrozenSet_CheckExact but no PySet_CheckExact.
@pablogsal pablogsal deleted the bpo-43277 branch May 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon

@methane methane Awaiting requested review from methane

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot