Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39199: Add attribution to the Green Tree Snakes in the AST docs #24727

Merged
merged 1 commit into from
Mar 3, 2021
Merged

bpo-39199: Add attribution to the Green Tree Snakes in the AST docs #24727

merged 1 commit into from
Mar 3, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 3, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Mar 3, 2021
@pablogsal pablogsal mentioned this pull request Mar 3, 2021
Merged
@pablogsal pablogsal added the needs backport to 3.9 only security fixes label Mar 3, 2021
pablogsal
pablogsal commented Mar 3, 2021
View reviewed changes
Doc/library/ast.rst
@@ -140,6 +140,11 @@ Node classes
In the meantime, instantiating them will return an instance of
a different class.

.. note::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have placed the note on the top, before the classes themselves as we already have a link to the project at the bottom of the page:

See also Green Tree Snakes, an external documentation resource, has good details on working with Python ASTs.

@pablogsal
Copy link
Member Author

CC @takluyver

brandtbucher
brandtbucher reviewed Mar 3, 2021
View reviewed changes
Doc/library/ast.rst Outdated Show resolved Hide resolved
takluyver
takluyver reviewed Mar 3, 2021
View reviewed changes
Doc/library/ast.rst Outdated Show resolved Hide resolved
@willingc
Copy link
Contributor

willingc commented Mar 3, 2021 •
edited
Loading

Thanks @pablogsal. As soon as @takluyver approves of the content, let's ship this. One of these days I would love to see @takluyver have core dev privileges.

@pablogsal
Copy link
Member Author

Thanks @pablogsal. As soon as @takluyver approves of the content, let's ship this. One of these days I would love to see @takluyver have core dev privileges.

Thanks for the review. @takluyver approved in this comment:

#24727 (comment)

So I am landing this :)

@pablogsal pablogsal merged commit 62e3b63 into python:master Mar 3, 2021
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2021
@pablogsal @miss-islington
Add an attribution to the Green Tree Snakes in the AST docs (pythonGH…
e327a35 
…-24727)

(cherry picked from commit 62e3b63)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-24731 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 3, 2021
miss-islington added a commit that referenced this pull request Mar 3, 2021
@miss-islington @pablogsal
Add an attribution to the Green Tree Snakes in the AST docs (GH-24727)
ff6a021 
(cherry picked from commit 62e3b63)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@pablogsal @kreathon
Add an attribution to the Green Tree Snakes in the AST docs (pythonGH…
b5d118d 
…-24727)
@pablogsal pablogsal deleted the ast_docs branch May 19, 2021 18:59
@pablogsal pablogsal mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takluyver takluyver takluyver left review comments

@brandtbucher brandtbucher brandtbucher left review comments

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pablogsal @willingc @miss-islington @bedevere-bot @takluyver @brandtbucher @the-knights-who-say-ni