-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43705: Document that SyntaxError's offsets are 1-indexed #25153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tightening up the words a bit.
@ammaraskar: Status check is done, and it's a success ✅ . |
Thanks @ammaraskar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
GH-25155 is a backport of this pull request to the 3.9 branch. |
GH-25156 is a backport of this pull request to the 3.8 branch. |
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
bpo-43705: Document that SyntaxError's offsets are 1-indexed (pythonGH-25153)
…H-25153) Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum
Changed the inline mentions of the attributes into a proper attribute list like
SystemExit
has.https://bugs.python.org/issue43705
Automerge-Triggered-By: GH:gvanrossum