bpo-43795: PEP-652: Simplify headers for easier static analysis #25483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes static analysis easier. From discussion at https://discuss.python.org/t/pep-652-maintaining-the-stable-abi/6986/13 it is clear that: - parsing C to get information is okay (though I personally prefer to *generate* it) - writing a full C parser is a monumental task (and adding an existing one as a dependency is not feasible) I think it's reasonable to simplify our declarations in order to make header checks easier, rather than write a parser that can handle all C.
This makes static analysis of the headers easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the PEP-652 implementation, I'll tighten the CI check
for functions/data defined with
Py_LIMITED_API.Discussion in https://discuss.python.org/t/pep-652-maintaining-the-stable-abi/6986
suggests that parsing C headers is OK (though personally I'd rather generate it...),
but writing a full C parser is a monumental task and adding an existing one as a
dependency brings too many vendoring/bootstraping issues.
So, for the check I'll use a "simple" regex on preprocessor output, and adapt
the few trivial places where the regex won't work.
_Py_NO_RETURN, so the annotation can beremoved from preprocessor output.
https://bugs.python.org/issue43795