Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44135: issubclass documentation doesn't explain tuple semantic #26193

Merged
merged 1 commit into from
Aug 31, 2021
Merged

bpo-44135: issubclass documentation doesn't explain tuple semantic #26193

merged 1 commit into from
Aug 31, 2021

Conversation

zkneupper
Copy link
Contributor

@zkneupper zkneupper commented May 17, 2021 •
edited by bedevere-bot
Loading

bpo-44135: issubclass documentation doesn't explain tuple semantic

[bpo-44135](https://bugs.python.org/issue44135): issubclass documentation doesn't explain tuple semantic

https://bugs.python.org/issue44135

https://bugs.python.org/issue44135

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 17, 2021
@zkneupper zkneupper changed the title Address https://bugs.python.org/issue44135 bpo-44135: issubclass documentation doesn't explain tuple semantic May 17, 2021
Fidget-Spinner
Fidget-Spinner approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for submitting this PR.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented May 17, 2021 •
edited
Loading

BTW, I think it would be better if your issue title summarised what the change is about. So maybe bpo-xxxxx:improve explanation of tuple semantics in issubclass docs or something like that?

@zkneupper
Copy link
Contributor Author

BTW, I think it would be better if your issue title summarised what the change is about. So maybe bpo-xxxxx:improve explanation of tuple semantics in issubclass docs or something like that?

Thanks for the suggestion. I'll try to do a better job of naming PRs in the future. :)

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 17, 2021
@Fidget-Spinner Fidget-Spinner removed the needs backport to 3.9 only security fixes label Aug 31, 2021
@Fidget-Spinner
Copy link
Member

Sorry for the long wait Zack.

@ambv sorry can I trouble you to take a look at this please? I'd appreciate a second pair of eyes.

@ambv ambv merged commit 08767c7 into python:main Aug 31, 2021
@miss-islington
Copy link
Contributor

Thanks @zkneupper for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 31, 2021
@zkneupper @miss-islington
bpo-44135: Refine explanation of how passing tuples to issubclass() b…
dcc4e25 
…ehaves (pythonGH-26193)

Co-authored-by: Zachary Kneupper <zachary.kneupper@gmail.com>
(cherry picked from commit 08767c7)

Co-authored-by: Zack Kneupper <zachary.kneupper@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 31, 2021
@bedevere-bot
Copy link

GH-28091 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Aug 31, 2021
@miss-islington @zkneupper
bpo-44135: Refine explanation of how passing tuples to issubclass() b…
ab8fed8 
…ehaves (GH-26193)

Co-authored-by: Zachary Kneupper <zachary.kneupper@gmail.com>
(cherry picked from commit 08767c7)

Co-authored-by: Zack Kneupper <zachary.kneupper@gmail.com>
ambv added a commit to ambv/cpython that referenced this pull request Aug 31, 2021
@ambv
bpo-44135: Refine explanation of how passing tuples to issubclass() b…
42cceb9 
…ehaves (pythonGH-26193)

This is a quasi-backport to 3.9 since the wording in this branch is different.

Co-authored-by: Zachary Kneupper zachary.kneupper@gmail.com
ambv added a commit that referenced this pull request Aug 31, 2021
@ambv
bpo-44135: Refine explanation of how passing tuples to issubclass() b…
5f66ad0 
…ehaves (GH-26193) (GH-28094)

This is a quasi-backport to 3.9 since the wording in this branch is different.

Co-authored-by: Zachary Kneupper zachary.kneupper@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news sprint stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zkneupper @Fidget-Spinner @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni