Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44270: shutil.which: windows path/cmd searches pathext #26458

Closed
wants to merge 1 commit into from
Closed

bpo-44270: shutil.which: windows path/cmd searches pathext #26458

wants to merge 1 commit into from

Conversation

scivision
Copy link

@scivision scivision commented May 31, 2021

previously, the early short-circuit logic for shutil.which(cmd) where cmd includes a directory
component incorrectly gave None on Windows if the correct filename suffix was not also given.

For example, on Windows shutil.which("./foo") would not
find existing executable file ./foo.exe. Now it does.

https://bugs.python.org/issue44270

previously, the early short-circuit when cmd includes a directory
component incorrectly gave None on Windows if the correct filename
suffix was not also given.
For example, on Windows `shutil.which("c:\Python\python") would not
find the file c:\Python\python.exe. Now it does.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@scivision

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 1, 2021
@github-actions
Copy link

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions bot closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants