Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44409: Fix error location in tokenizer errors that happen during initialization #26712

Merged
merged 2 commits into from
Jun 14, 2021
Merged

bpo-44409: Fix error location in tokenizer errors that happen during initialization #26712

merged 2 commits into from
Jun 14, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 13, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Jun 13, 2021
lysnikolaou
lysnikolaou reviewed Jun 14, 2021
View reviewed changes
Parser/pegen.c Outdated Show resolved Hide resolved
pablogsal
pablogsal commented Jun 14, 2021
View reviewed changes
Parser/pegen.c Outdated Show resolved Hide resolved
lysnikolaou
lysnikolaou approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@pablogsal pablogsal merged commit 507ed6f into python:main Jun 14, 2021
@pablogsal pablogsal deleted the bpo-44409 branch June 14, 2021 16:46
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 507ed6fa1d6661e0f8e6d3282764aa9625a99594 3.9

@bedevere-bot
Copy link

GH-26722 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 14, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2021
@pablogsal @miss-islington
bpo-44409: Fix error location in tokenizer errors that happen during …
82ce4c8 
…initialization (pythonGH-26712)

(cherry picked from commit 507ed6f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 14, 2021
@bedevere-bot
Copy link

GH-26723 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 14, 2021
@pablogsal
[3.9] bpo-44409: Fix error location in tokenizer errors that happen d…
8145c6e 
…uring initialization (pythonGH-26712).

(cherry picked from commit 507ed6f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Jun 14, 2021
@miss-islington @pablogsal
bpo-44409: Fix error location in tokenizer errors that happen during …
133cddf 
…initialization (GH-26712)

(cherry picked from commit 507ed6f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 14, 2021
@pablogsal
[3.9] bpo-44409: Fix error location in tokenizer errors that happen d…
0d0a9ea 
…uring initialization (GH-26712). (GH-26723)

(cherry picked from commit 507ed6f)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
@pablogsal @jdevries3133
bpo-44409: Fix error location in tokenizer errors that happen during …
ed3d0b5 
…initialization (pythonGH-26712)
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni