-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-27752: improve documentation of csv.Dialect #26795
Conversation
* There are *no* content changes in this commit * gqap in vim: it's a beautiful thing.
The formatting (whitespace?) changes are unlikely to be approved. You should limit this PR to the content change you are making (possibly fix typos in other places). The PR will be squashed into one commit, so the diff will be huge and hide the actual change. Sweeping whitespace-type changes are not going to be accepted in a separate PR either because they spam the commit log and the "blame" outputs. |
This reverts commit c5eb845.
@iritkatriel Ok, those changes have been reverted. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't mind me; just talking to myself. When this was marked stale,I opened it up and saw these issues. I will fix them soon, but don't want anyone to waste their time reviewing in the interim.
You can mark the PR as draft and then people won't review it until you say it's ready. |
* revert all whitespace changes * revert new paragraph; old paragraph looked better
@iritkatriel Yes, well the other factor here is that I was reading the diff just before bed and wanted to leave myself the notes as breadcrumbs, too! Anyway, this PR is ready for another review, I think it is ready to go. The diff is much smaller as I got rid of all whitespace changes, plus a lot of pedantic changes that I can now see were unnecessary. A summary of the changes now are:
|
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
GH-27643 is a backport of this pull request to the 3.10 branch. |
Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 0ffdced) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
GH-27644 is a backport of this pull request to the 3.9 branch. |
Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 0ffdced) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
Note that all content changes are in the first commit. The second commit is 100% formatting of the
rst
file. There are also some very minor proofreading corrections in the final commit.I'm very open to feedback on this; please let me know if there are any bits in here that you feel could be communicated better!
https://bugs.python.org/issue27752