Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-44297: Fix missing line number in generator expressions (Backport of GH-26801) #26821

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[3.10] bpo-44297: Fix missing line number in generator expressions (Backport of GH-26801) #26821

merged 1 commit into from
Jun 21, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jun 21, 2021 •
edited by bedevere-bot
Loading

  • Make sure that line number is set when entering comprehension scope in compiler.

(cherry picked from commit 82e5c28)

https://bugs.python.org/issue44297

@markshannon
bpo-44297: Fix missing line number in generator expressions (pythonGH…
b933e81 
…-26801)

* Make sure that line number is set when entering comprehension scope in compiler.

(cherry picked from commit 82e5c28)
@markshannon
Copy link
Member Author

@pablogsal Given that this has a news entry, should I remove the equivalent news entry from 3.11?

@markshannon markshannon merged commit 7674c83 into python:3.10 Jun 21, 2021
@pablogsal
Copy link
Member

pablogsal commented Jun 21, 2021 •
edited
Loading

@pablogsal Given that this has a news entry, should I remove the equivalent news entry from 3.11?

No, as this is a backport the news entry should be the same. (The change should appear in both branches)

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @pablogsal @the-knights-who-say-ni @bedevere-bot