Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40897:Give priority to using the current class constructor in inspect.signature #27177

Merged
merged 2 commits into from
Jul 16, 2021
Merged

bpo-40897:Give priority to using the current class constructor in inspect.signature #27177

merged 2 commits into from
Jul 16, 2021

Conversation

hongweipeng
Copy link
Contributor

@hongweipeng hongweipeng commented Jul 16, 2021 •
edited by bedevere-bot
Loading

@mauvilsa
Copy link

@hongweipeng could you please comment here or in https://bugs.python.org/issue40897 if this fixes what I commented about the datetime classes. If it does fix it, would it be okay to add a unit test which checks getting the signature of e.g. datetime.timedelta?

@ambv
Copy link
Contributor

ambv commented Jul 16, 2021

@mauvilsa, as you rightfully noticed yourself, this is a separate issue. Thanks for creating BPO-44618, we will deal with this separately.

@ambv
Copy link
Contributor

ambv commented Jul 16, 2021

Address sanitizer failure unrelated.

@ambv ambv merged commit 6aab5f9 into python:main Jul 16, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 16, 2021
@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

@miss-islington
Copy link
Contributor

Sorry @hongweipeng and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.10

@sthagen sthagen mentioned this pull request Jul 16, 2021
Merged
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes needs backport to 3.9 only security fixes labels Jul 16, 2021
@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27189 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2021
@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
007cf76 
…spect.signature` (pythonGH-27177)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@ambv ambv removed the needs backport to 3.9 only security fixes label Jul 16, 2021
ambv pushed a commit that referenced this pull request Jul 16, 2021
@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
948e39a 
…spect.signature` (GH-27177) (#27189)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@ambv ambv mentioned this pull request Jul 16, 2021
Merged
@ambv ambv added the needs backport to 3.9 only security fixes label Jul 17, 2021
@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27209 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 17, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
e1e5a3b 
…spect.signature` (pythonGH-27177)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
ambv pushed a commit that referenced this pull request Jul 17, 2021
@miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
df7c629 
…spect.signature` (GH-27177) (GH-27209)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@hongweipeng hongweipeng deleted the inspect-signature-use-current-class-first branch December 5, 2021 14:48
@mauvilsa mauvilsa mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hongweipeng @mauvilsa @ambv @bedevere-bot @miss-islington @the-knights-who-say-ni