Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44792: Improve syntax errors for if expressions #27506

Merged
merged 1 commit into from
Aug 2, 2021
Merged

bpo-44792: Improve syntax errors for if expressions #27506

merged 1 commit into from
Aug 2, 2021
+48 −0

Conversation

miguendes
Copy link
Contributor

@miguendes miguendes commented Jul 31, 2021 •
edited by bedevere-bot
Loading

@miguendes miguendes changed the title Improve syntax errors for if expressions bpo-44792: Improve syntax errors for if expressions Jul 31, 2021
pablogsal
pablogsal requested changes Jul 31, 2021
View reviewed changes
Grammar/python.gram Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miguendes miguendes force-pushed the bpo-44792 branch 2 times, most recently from 6106656 to cfdf3c4 Compare July 31, 2021 14:53
@miguendes miguendes requested a review from pablogsal July 31, 2021 14:53
@pablogsal
Copy link
Member

You need to run make regen-pegen to regenerate the parser files as well @miguendes

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 31, 2021
@miguendes
Copy link
Contributor Author

You need to run make regen-pegen to regenerate the parser files as well @miguendes

Thanks @pablogsal It works now, but there's an asyncio and concurrent.futures tests failing on Windows PR Tests win64. Could they be related?

@pablogsal
Copy link
Member

You need to run make regen-pegen to regenerate the parser files as well @miguendes

Thanks @pablogsal It works now, but there's an asyncio and concurrent.futures tests failing on Windows PR Tests win64. Could they be related?

Unless is a syntax error is unlikely. I will investigate...

@pablogsal pablogsal closed this Jul 31, 2021
@pablogsal pablogsal reopened this Jul 31, 2021
@pablogsal pablogsal merged commit 28b6dc9 into python:main Aug 2, 2021
@miss-islington
Copy link
Contributor

Thanks @miguendes for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 2, 2021
@bedevere-bot
Copy link

GH-27565 is a backport of this pull request to the 3.10 branch.

@pablogsal
Copy link
Member

Thanks for your contribution @miguendes ! 🎉

pablogsal pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2021
@miguendes @pablogsal
bpo-44792: Improve syntax errors for if expressions (pythonGH-27506)
8dacb9e 
(cherry picked from commit 28b6dc9)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Aug 2, 2021
@miss-islington @miguendes
bpo-44792: Improve syntax errors for if expressions (GH-27506) (GH-27565
5671762 
)

(cherry picked from commit 28b6dc9)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miguendes @bedevere-bot @pablogsal @miss-islington @the-knights-who-say-ni