Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-33349: make lib2to3 parse async generators everywhere (GH-6588) #27702

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[3.10] bpo-33349: make lib2to3 parse async generators everywhere (GH-6588) #27702

merged 1 commit into from
Aug 10, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 10, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit 149addd)

Co-authored-by: Zsolt Dollenstein zsol.zsol@gmail.com

https://bugs.python.org/issue33349

@zsol @miss-islington
make lib2to3 parse async generators everywhere (pythonGH-6588)
ab32aaa 
(cherry picked from commit 149addd)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
@miss-islington
Copy link
Contributor Author

@zsol and @ambv: Status check is done, and it's a failure ❌ .

@bedevere-bot bedevere-bot mentioned this pull request Aug 10, 2021
Merged
@miss-islington
Copy link
Contributor Author

@zsol and @ambv: Status check is done, and it's a failure ❌ .

@ambv ambv changed the title [3.10] make lib2to3 parse async generators everywhere (GH-6588) [3.10] bpo-33349: make lib2to3 parse async generators everywhere (GH-6588) Aug 10, 2021
@miss-islington
Copy link
Contributor Author

@zsol and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv requested a review from pablogsal August 10, 2021 09:55
@ambv
Copy link
Contributor

ambv commented Aug 10, 2021

@pablogsal, while lib2to3 is deprecated, it was unable to parse valid 3.7+ code with regular functions that created async generators. This fixes it.

@miss-islington miss-islington merged commit 52d481f into python:3.10 Aug 10, 2021
@miss-islington miss-islington deleted the backport-149addd-3.10 branch August 10, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot @zsol