Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44903: Removed othergui.rst and list of GUI frameworks #27762

Merged
merged 3 commits into from
Aug 17, 2021
Merged

bpo-44903: Removed othergui.rst and list of GUI frameworks #27762

merged 3 commits into from
Aug 17, 2021

Conversation

quantumgc
Copy link
Contributor

@quantumgc quantumgc commented Aug 13, 2021 •
edited by bedevere-bot
Loading

In their places I've added links to the python wiki page on GUI frameworks.

https://bugs.python.org/issue44903

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Aug 13, 2021
@quantumgc quantumgc force-pushed the bpo-44903 branch 2 times, most recently from dfc59e3 to 27f995c Compare August 13, 2021 19:27
zware
zware requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'd say this is going in the right direction and about 90% there :)

Doc/faq/gui.rst Outdated
@@ -14,102 +14,15 @@ Graphic User Interface FAQ
General GUI Questions
=====================

What platform-independent GUI toolkits exist for Python?
What GUI toolkits exist for Python?
========================================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: shorten the underline to match the heading:

Suggested change
========================================================
===================================

Doc/faq/gui.rst Show resolved Hide resolved
Doc/library/tk.rst Outdated
been vastly improved in Tk 8.5. Nevertheless, there are many other GUI libraries
that you could be interested in. The Python wiki lists several of these
alternative `GUI frameworks and tools
<https://wiki.python.org/moin/GuiProgramming>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like most of the change here is just reflowing the text, which makes it harder to review. Could you please revert the reflow?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@quantumgc
Copy link
Contributor Author

I've reverted the reflow and shortened the underline. I kept the original paragraph on tkinter, just moving it upwards and slightly changing the paragraph which mentions the alternatives.

@quantumgc quantumgc requested a review from zware August 13, 2021 20:11
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 17, 2021
@ambv ambv merged commit 6a358bb into python:main Aug 17, 2021
@miss-islington
Copy link
Contributor

Thanks @quantumgc for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @quantumgc and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6a358bb9482f7595b858ea7b800cbe66f0de5fa1 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 17, 2021
@bedevere-bot
Copy link

GH-27790 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2021
@quantumgc @miss-islington
bpo-44903: Removed othergui.rst and list of GUI frameworks (pythonGH-…
cea7b58 
…27762)

(cherry picked from commit 6a358bb)

Co-authored-by: Gautam Chaudhuri <gautam.chaudhuri.1803@gmail.com>
@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Aug 17, 2021
@miss-islington
Copy link
Contributor

Thanks @quantumgc for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2021
@quantumgc @miss-islington
bpo-44903: Removed othergui.rst and list of GUI frameworks (pythonGH-…
8d1ad91 
…27762)

(cherry picked from commit 6a358bb)

Co-authored-by: Gautam Chaudhuri <gautam.chaudhuri.1803@gmail.com>
@bedevere-bot
Copy link

GH-27791 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 17, 2021
miss-islington added a commit that referenced this pull request Aug 17, 2021
@miss-islington @quantumgc
bpo-44903: Removed othergui.rst and list of GUI frameworks (GH-27762)
f6bd1ca 
(cherry picked from commit 6a358bb)

Co-authored-by: Gautam Chaudhuri <gautam.chaudhuri.1803@gmail.com>
ambv pushed a commit that referenced this pull request Aug 17, 2021
@miss-islington @quantumgc
bpo-44903: Removed othergui.rst and list of GUI frameworks (GH-27762) (…
e21b66b 
…GH-27790)

(cherry picked from commit 6a358bb)

Co-authored-by: Gautam Chaudhuri <gautam.chaudhuri.1803@gmail.com>
@quantumgc quantumgc deleted the bpo-44903 branch August 17, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware Awaiting requested review from zware

Assignees

@ambv ambv

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@quantumgc @bedevere-bot @miss-islington @zware @ambv @the-knights-who-say-ni