Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44852: Support filtering over warnings without a set message #27793

Merged
merged 2 commits into from
Aug 18, 2021
Merged

bpo-44852: Support filtering over warnings without a set message #27793

merged 2 commits into from
Aug 18, 2021

Conversation

ambv
Copy link
Contributor

@ambv ambv commented Aug 17, 2021 •
edited
Loading

Turns out that the asyncio test suite on Windows contains deprecation warnings with None in the message field. When working on GH-27569 those caused test crashes.

Additional improvements:

  • messages which were compiled regular expressions aren't unpacked back into
    strings for unmatched warnings;

  • removed unnecessary "if tokens:" check (there's one before the for loop).

https://bugs.python.org/issue44852

@ambv
bpo-44852: Support filtering over warnings without a set message
86f24c9 
Additional improvements:

- messages which were compiled regular expressions aren't unpacked back into
  strings for unmatched warnings;

- removed unnecessary "if tokens:" check (there's one before the for loop).
@ambv ambv added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 17, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 86f24c9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2021
@ambv
Copy link
Contributor Author

ambv commented Aug 17, 2021

The buildbot/AMD64 Windows10 PR failure is an unrelated memory error:

======================================================================
ERROR: test_stack_overflow (test.test_compile.TestSpecifics)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\buildarea\pull_request.bolen-windows10\build\lib\test\test_compile.py", line 718, in test_stack_overflow
    compile("if a: b\n" * 200000, "<dummy>", "exec")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError

@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 1047974 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 17, 2021
ambv added a commit to Dreamsorcerer/cpython that referenced this pull request Aug 17, 2021
@ambv
Update like in pythonGH-27793
2de9fde
@ambv
Copy link
Contributor Author

ambv commented Aug 18, 2021

The Windows10 buildbot seems unhealthy. On GH-27569 it's now failing with "fatal error C1060: compiler is out of heap space". Reported to the buildbot owner.

@ambv ambv requested a review from pablogsal August 18, 2021 11:00
@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 18, 2021
@ambv
Copy link
Contributor Author

ambv commented Aug 18, 2021

Merging. The Docs job is stuck here but the PR's got no docs changes. The Win 10 buildbot is broken at the moment, and the ASAN failure is some volatile failure ("RuntimeError: subprocess not supported for isolated subinterpreters").

@ambv ambv merged commit 8cf07d3 into python:main Aug 18, 2021
@miss-islington
Copy link
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@ambv ambv deleted the bpo-44852-followup branch August 18, 2021 11:19
@bedevere-bot
Copy link

GH-27809 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 18, 2021
@bedevere-bot
Copy link

GH-27810 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 18, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2021
@ambv @miss-islington
bpo-44852: Support filtering over warnings without a set message (pyt…
0be22a0 
…honGH-27793)

Additional improvements:

- messages which were compiled regular expressions aren't unpacked back into
  strings for unmatched warnings;

- removed unnecessary "if tokens:" check (there's one before the for loop);

- took `endswith` calculation out of the for loop.
(cherry picked from commit 8cf07d3)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2021
@ambv @miss-islington
bpo-44852: Support filtering over warnings without a set message (pyt…
d53433a 
…honGH-27793)

Additional improvements:

- messages which were compiled regular expressions aren't unpacked back into
  strings for unmatched warnings;

- removed unnecessary "if tokens:" check (there's one before the for loop);

- took `endswith` calculation out of the for loop.
(cherry picked from commit 8cf07d3)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington added a commit that referenced this pull request Aug 18, 2021
@miss-islington @ambv
bpo-44852: Support filtering over warnings without a set message (GH-…
d1c0e44 
…27793)

Additional improvements:

- messages which were compiled regular expressions aren't unpacked back into
  strings for unmatched warnings;

- removed unnecessary "if tokens:" check (there's one before the for loop);

- took `endswith` calculation out of the for loop.
(cherry picked from commit 8cf07d3)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Aug 18, 2021
@miss-islington @ambv
bpo-44852: Support filtering over warnings without a set message (GH-…
ebe7e6d 
…27793) (GH-27810)

Additional improvements:

- messages which were compiled regular expressions aren't unpacked back into
  strings for unmatched warnings;

- removed unnecessary "if tokens:" check (there's one before the for loop);

- took `endswith` calculation out of the for loop.
(cherry picked from commit 8cf07d3)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ambv @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni