Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio. #28153

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 4, 2021

Deprecation warnings about the loop argument were incorrectly emitted
in cases when the loop argument was used inside the asyncio library,
not from user code.

https://bugs.python.org/issue45097

Deprecation warnings about the loop argument were incorrectly emitted
in cases when the loop argument was used inside the asyncio library,
not from user code.
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when all checks are green. Thanks!

@serhiy-storchaka serhiy-storchaka changed the title bpo-45097: Remove incorrect deprecation warnings in asyncio. [3.9] bpo-45097: Remove incorrect deprecation warnings in asyncio. Sep 4, 2021
@serhiy-storchaka serhiy-storchaka merged commit c967bd5 into python:3.9 Sep 4, 2021
@serhiy-storchaka serhiy-storchaka deleted the asyncio-deprecation-warnings-3.9 branch September 4, 2021 17:54
jonringer added a commit to jonringer/nixpkgs that referenced this pull request Sep 13, 2021
Will eventually be fixed by: python/cpython#28153
on next cpython release
StephenWithPH pushed a commit to StephenWithPH/nixpkgs that referenced this pull request Sep 24, 2021
Will eventually be fixed by: python/cpython#28153
on next cpython release
mweinelt pushed a commit to mweinelt/nixpkgs that referenced this pull request Oct 3, 2021
Will eventually be fixed by: python/cpython#28153
on next cpython release
a-feld added a commit to a-feld/pywreck that referenced this pull request Oct 7, 2021
Python v3.9.7 loop.create_server internally uses the loop argument to
call gather, resulting in a warning being generated.
https://github.com/python/cpython/blob/v3.9.7/Lib/asyncio/base_events.py#L1460

This has been fixed, but not yet released:
python/cpython#28153
@kevr
Copy link

kevr commented Oct 23, 2021

Is there a planned tagging of this? It's quite the problem, and we could definitely use this change as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants