Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011) #28196

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 7, 2021

(cherry picked from commit 4f88161)

Co-authored-by: Tzu-ping Chung uranusjr@gmail.com

https://bugs.python.org/issue45035

…8011)

(cherry picked from commit 4f88161)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@miss-islington
Copy link
Contributor Author

@uranusjr and @pablogsal: Status check is done, and it's a success ✅ .

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting confIrmation from @encukou

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly the wasn't much discussion, but I don't think this should be merged.

@pablogsal pablogsal closed this Sep 7, 2021
@miss-islington miss-islington deleted the backport-4f88161-3.10 branch September 7, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants