bpo-30732: json.dumps() lacks information about RecursionError relate… #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to default function
mlouielu
reviewed
Jul 25, 2017
Modules/_json.c
Outdated
| @@ -1503,6 +1503,13 @@ encoder_listencode_obj(PyEncoderObject *s, _PyAccu *acc, | |||
| } | |||
| } | |||
| newobj = PyObject_CallFunctionObjArgs(s->defaultfn, obj, NULL); | |||
| if (obj != NULL && newobj != NULL && newobj->ob_type == obj->ob_type) { | |||
There was a problem hiding this comment.
How about if (PyObject_IsInstance(newobj, (PyObject *) Py_TYPE(obj))) { ?
Also, I think this can put above the check of if (newobj == NULL)
There was a problem hiding this comment.
Wouldn't PyObject_IsInstance raise false positives for our condition? For this fix, we would want the exact types to match, isn't it?
…d to default function
…d to default function
|
Ignore the identation changes please, its still not aligned. |
…d to default function
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
|
I was not able to modify the original PR, so I created a new one: #113458. |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review.
https://bugs.python.org/issue30732
#74917