-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-10572: Move sqlite3
tests to Lib/test
#29304
bpo-10572: Move sqlite3
tests to Lib/test
#29304
Conversation
deleted Lib/sqlite3/test/__init__.py renamed /test/test_sqlite.py -> Lib/test/test_sqlite3/__init__.py renamed /sqlite3/test/test_backup.py -> Lib/test/test_sqlite3/test_backup.py renamed /sqlite3/test/test_dbapi.py -> Lib/test/test_sqlite3/test_dbapi.py renamed /sqlite3/test/test_dump.py -> Lib/test/test_sqlite3/test_dump.py renamed /sqlite3/test/test_factory.py -> Lib/test/test_sqlite3/test_factory.py renamed /sqlite3/test/test_hooks.py -> Lib/test/test_sqlite3/test_hooks.py renamed /sqlite3/test/test_regression.py -> Lib/test/test_sqlite3/test_regression.py renamed /sqlite3/test/test_transactions.py -> Lib/test/test_sqlite3/test_transactions.py renamed /sqlite3/test/test_types.py -> Lib/test/test_sqlite3/test_types.py renamed /sqlite3/test/test_userfunctions.py -> Lib/test/test_sqlite3/test_userfunctions.py
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <brett@python.org>
This reverts commit 35f6334 and adds a comment on why it was needed
I believe I have made the requested changes; please review again. |
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
It all LGTM, I just want to double-check the tests still run, so I'm waiting on CI to finish at least one of the test runs. 😄 |
@erlend-aasland: Status check is done, and it's a failure ❌ . |
@erlend-aasland: Status check is done, and it's a success ✅ . |
Thanks, Brett! |
|
See GH-29327 for the buildbot fix. |
We should consider mentioning this change in the 3.11 What's New document. Re #94998. |
Proposed What's New entry in gh-95059. |
https://bugs.python.org/issue10572
Automerge-Triggered-By: GH:brettcannon