New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45855: document that no_block
has no use anymore in PyCapsule_Import
#29665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the review! I'm not up to date on NEWS policy; I don't think this needs an entry, can I just set the "skip news" label? |
One sentence NEWS doesn't harm. Usually, we skip news for very trivial changes only, e.g. typo fixing. |
Superseded by #30046 |
Uh no, it is not superseded. The other PR just changed a couple of calls, among others it "fixed" the location I changed in capsule.c to call the same function twice in an if-else instead of removing the branch. |
…mport and also remove the switch in the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry.
LGTM, please feel free to merge.
Thanks! |
@birkenfeld: Please replace |
and also remove the switch in the implementation.
https://bugs.python.org/issue45855