Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydoc html: parse https links #2975

Closed
wants to merge 1 commit into from
Closed

pydoc html: parse https links #2975

wants to merge 1 commit into from

Conversation

python273
Copy link
Contributor

No description provided.

@python273
Copy link
Contributor Author

Contributor Form Received | Yes on: 2017-08-01.00:00:00

parrot

@Mariatta
Copy link
Member

Thanks for the PR. I think this change requires an issue in the b.p.o, a News entry and tests.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue on the bug tracker for discussion.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@csabella
Copy link
Contributor

@python273 Thank you for the suggested change and for the PR! If you've opened a bug tracker ticket per @serhiy-storchaka's review, please update the PR title with the bpo number. If you haven't yet opened a ticket, please do so in order for review of this PR to proceed. Also, please make the changes suggested by @Mariatta. Thanks!

@mariatta-bot
Copy link

Mariatta was mentioned, but she's out of open source from March 18th to May 9th, 2019 . Be aware she might not get to this until after PyCon US.
(I'm a bot)

@csabella
Copy link
Contributor

I am closing this issue. Feel free to re-open once the concerns have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants