Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45774: Harden SQLite detection #30016

Merged
merged 9 commits into from
Apr 5, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 9, 2021

  • Beautify configure output
  • Make sure vital functions are in place

https://bugs.python.org/issue45774

Automerge-Triggered-By: GH:tiran

- Beautify configure output
- Make sure vital functions are in place
configure Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f5b0552 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Dec 14, 2021

Regarding the buildbot run: SQLite is correctly detected and the sqlite3 module is built, AFAICS. The two failures seem to be unrelated.

@erlend-aasland
Copy link
Contributor Author

@tiran, are you ok with this PR? For those of us who've got multiple SQLite installations with completely different configurations, it's nice to fail early with configure rather than wait for a link error at the end of compilation.

@erlend-aasland
Copy link
Contributor Author

Regarding the buildbot run:

  • AMD64 Arch Linux ASAN failed at test_multiprocessing_fork
  • PPC64LE RHEL7 Refleaks failed at test_typing

Both failures are unrelated to this PR.

@erlend-aasland
Copy link
Contributor Author

@tiran: 🏓

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library. But if they do, this likely does a better job at detecting that and avoiding it.

@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit e8558da 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2022
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Mar 4, 2022

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library.

I do, I do! ✋🏻 (Mostly for testing weird stuff like this)

OTOH, we never know what kind of SQLite library will show up when we're running Python in the browser.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 55f79a5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 5, 2022
@arhadthedev
Copy link
Member

@tiran PPC64LE failure is sporadic, a rerun is required:

fatal: unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.com

@tiran
Copy link
Member

tiran commented Apr 5, 2022

@tiran PPC64LE failure is sporadic, a rerun is required:

fatal: unable to access 'python/cpython.git': Could not resolve host: github.com

The buildbot started to fail consistently two days ago. I have contacted Charris to look into the problem an hour ago.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

16 similar comments
@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@tiran
Copy link
Member

tiran commented Apr 5, 2022

The Windows refleak, PPC64LE, and s390x issues are unrelated to the PR. The s390x issue is addressed in GH-32332.

@tiran tiran merged commit f1606a5 into python:main Apr 5, 2022
@erlend-aasland erlend-aasland deleted the ac-harden-sqlite-detection branch April 5, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants