Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-26571-Class variable _RUNNING update at the __init__ end #30332

Closed
wants to merge 4 commits into from

Conversation

williamnavaraj
Copy link

@williamnavaraj williamnavaraj commented Jan 2, 2022

Initialising the class variable at the end of the object initialisation method. This will help to run this library smoothly in use cases such as in Jupyter or ipython or spyder or GUI or other cell based execution as well as the usual self contained script or module execution.
Related bugs: https://bugs.python.org/issue26571
Will solve problems highlighted repeatedly in these stack overflow posts (With 1000s of views, current suggestions are some non-elegant work arounds such as importlib.reload(turtle) or or try-except and initializing again in the except as the _RUNNING becomes true at the end of last run or manually setting the _RUNNING flag). More logical to turn this to True after the initialization rather than during terminator exception. Have tested it with various demo cases and examples. No problem found with this update.
https://stackoverflow.com/questions/45534458/python-turtle-terminator-even-after-using-exitonclick
https://stackoverflow.com/questions/34956937/weird-terminator-error-when-running-python-3-turtle-in-os-x
https://stackoverflow.com/questions/70252586/turtle-module-for-langtons-ant-in-python-giving-me-raise-terminator-turtle-ter
https://stackoverflow.com/questions/58078376/a-function-i-created-can-only-be-called-once-second-time-it-shows-an-error
https://stackoverflow.com/questions/54198108/how-can-i-close-a-window-after-using-turtle
https://stackoverflow.com/questions/67734319/running-turtle-multiple-times-but-receiving-a-terminator-error-after-the-first-r
https://stackoverflow.com/questions/43294665/turtle-done-not-working-in-spyder
https://stackoverflow.com/questions/50438762/python-turtle-window-crashes-every-2nd-time-running
https://stackoverflow.com/questions/41644324/how-to-close-python-turtle-properly
https://stackoverflow.com/questions/41548813/using-turtle-module-exitonclick/70552164
https://stackoverflow.com/questions/66750634/why-do-i-get-a-terminator-error-when-i-run-this-program
https://stackoverflow.com/questions/65546812/python-turtle-terminator
https://stackoverflow.com/questions/61963565/why-do-i-keep-getting-a-terminator-error-for-python-turtle

https://bugs.python.org/issue26571

Initialising the class variable at the end of the object initialisation method. This will help to run this library smoothly in use cases such as in Jupyter or ipython or spyder or GUI or other cell based execution. Will solve problems highlighted repeatedly in these stack overflow posts (With 1000s of views, current suggestions are some non-elegant work arounds such as importlib.reload(turtle) or or try-except and initializing again in the except as the _RUNNING becomes true at the end of last run or manually setting the _RUNNING flag).  More logical turn this to True after the initialization rather than during terminator exception.
https://stackoverflow.com/questions/45534458/python-turtle-terminator-even-after-using-exitonclick
https://stackoverflow.com/questions/34956937/weird-terminator-error-when-running-python-3-turtle-in-os-x
https://stackoverflow.com/questions/70252586/turtle-module-for-langtons-ant-in-python-giving-me-raise-terminator-turtle-ter
https://stackoverflow.com/questions/58078376/a-function-i-created-can-only-be-called-once-second-time-it-shows-an-error
https://stackoverflow.com/questions/54198108/how-can-i-close-a-window-after-using-turtle
https://stackoverflow.com/questions/67734319/running-turtle-multiple-times-but-receiving-a-terminator-error-after-the-first-r
https://stackoverflow.com/questions/43294665/turtle-done-not-working-in-spyder
https://stackoverflow.com/questions/50438762/python-turtle-window-crashes-every-2nd-time-running
https://stackoverflow.com/questions/41644324/how-to-close-python-turtle-properly
https://stackoverflow.com/questions/41548813/using-turtle-module-exitonclick/70552164
https://stackoverflow.com/questions/66750634/why-do-i-get-a-terminator-error-when-i-run-this-program
https://stackoverflow.com/questions/65546812/python-turtle-terminator
https://stackoverflow.com/questions/61963565/why-do-i-keep-getting-a-terminator-error-for-python-turtle
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@williamnavaraj

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

blurb-it bot and others added 3 commits January 2, 2022 07:31
Class variable _RUNNING update at the __init__ end
Initialising the class variable at the end of the object initialisation method. This will help to run this library smoothly in use cases such as in Jupyter or ipython or spyder or GUI or other cell based execution. Otherwise it will through raise Terminator error every second time. Will solve problems highlighted repeatedly in these stack overflow posts (With 1000s of views, current suggestions are some non-elegant work arounds such as importlib.reload(turtle) or or try-except and initializing again in the except as the _RUNNING becomes true at the end of last run or manually setting the _RUNNING flag).  More logical turn this to True after the initialization rather than during terminator exception.
https://stackoverflow.com/questions/45534458/python-turtle-terminator-even-after-using-exitonclick
https://stackoverflow.com/questions/34956937/weird-terminator-error-when-running-python-3-turtle-in-os-x
https://stackoverflow.com/questions/70252586/turtle-module-for-langtons-ant-in-python-giving-me-raise-terminator-turtle-ter
https://stackoverflow.com/questions/58078376/a-function-i-created-can-only-be-called-once-second-time-it-shows-an-error
https://stackoverflow.com/questions/54198108/how-can-i-close-a-window-after-using-turtle
https://stackoverflow.com/questions/67734319/running-turtle-multiple-times-but-receiving-a-terminator-error-after-the-first-r
https://stackoverflow.com/questions/43294665/turtle-done-not-working-in-spyder
https://stackoverflow.com/questions/50438762/python-turtle-window-crashes-every-2nd-time-running
https://stackoverflow.com/questions/41644324/how-to-close-python-turtle-properly
https://stackoverflow.com/questions/41548813/using-turtle-module-exitonclick/70552164
https://stackoverflow.com/questions/66750634/why-do-i-get-a-terminator-error-when-i-run-this-program
https://stackoverflow.com/questions/65546812/python-turtle-terminator
https://stackoverflow.com/questions/61963565/why-do-i-keep-getting-a-terminator-error-for-python-turtle
@williamnavaraj williamnavaraj deleted the patch-1 branch January 3, 2022 12:27
@gotyaoi gotyaoi mannequin mentioned this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants