Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46399: Expose DictKeysType, DictValuesType, and DictItemsType in … #30629

Closed
wants to merge 2 commits into from
Closed

bpo-46399: Expose DictKeysType, DictValuesType, and DictItemsType in … #30629

wants to merge 2 commits into from

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 17, 2022 •
edited by bedevere-bot

@kumaraditya303 kumaraditya303 mentioned this pull request Jan 17, 2022
Closed
@AlexWaygood
Copy link
Member

It would be good to add a line into the NEWS entry about why we're exposing them in types — something like "this makes it easier to add type annotations to certain mapping types"

@kumaraditya303
Copy link
Contributor Author

It would be good to add a line into the NEWS entry about why we're exposing them in types — something like "this makes it easier to add type annotations to certain mapping types"

That would be better in whatsnew of 3.11 I think.

@kumaraditya303 kumaraditya303 marked this pull request as ready for review January 17, 2022 10:27
@AlexWaygood
Copy link
Member

It would be good to add a line into the NEWS entry about why we're exposing them in types — something like "this makes it easier to add type annotations to certain mapping types"

That would be better in whatsnew of 3.11 I think.

Good point.

AlexWaygood
AlexWaygood requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this PR, could you add an entry in "What's New in Python 3.11", as discussed in the BPO issue? Thanks!

@kumaraditya303 kumaraditya303 deleted the issue46399 branch April 18, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood requested changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kumaraditya303 @AlexWaygood @the-knights-who-say-ni @bedevere-bot