Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46399: Add GenericAlias support to dict_keys, dict_values and dict_items types #30630

Closed
wants to merge 5 commits into from
Closed

bpo-46399: Add GenericAlias support to dict_keys, dict_values and dict_items types #30630

wants to merge 5 commits into from

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 17, 2022 •
edited by bedevere-bot
Loading

@AlexWaygood
Copy link
Member

Thank you!! We need to add a test to Lib/test/test_genericalias.py as well.

@devdanzin devdanzin mentioned this pull request Jan 19, 2022
Open
@AlexWaygood
Copy link
Member

(Closing and reopening to retrigger CI)

@AlexWaygood AlexWaygood reopened this Jan 19, 2022
@kumaraditya303 kumaraditya303 deleted the generic-types-dict branch April 18, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @AlexWaygood @the-knights-who-say-ni @bedevere-bot