bpo-41403: Improve error message for invalid mock target #30833

iritkatriel · 2022-01-23T17:40:22Z

https://bugs.python.org/issue41403

arhadthedev · 2022-01-23T17:59:48Z

Lib/unittest/mock.py

        raise TypeError("Need a valid target to patch. You supplied: %r" %
                        (target,))


Suggested change

raise TypeError("Need a valid target to patch. You supplied: %r" %

(target,))

raise TypeError(f"Need a valid target to patch. You supplied: {target}")

since there is a change of nearby lines anyway. Plus, "b'%r' is deprecated, but will not be removed during the 3.x series" in the docs.

Should be {target!r} I suppose?

Ah, yes. I was optimistic seeing string-only nature of target:

cpython/Lib/unittest/mock.py

Line 1693 in 461e59e

`target` should be a string in the form `'package.module.ClassName'`. The

Like, once it was an object requiring some special formatting but now it's just a string. However, I forgot that %r additionally escapes non-ascii code points.

Right, also this bpo is about the case where the error is that you passed in some non-string object.

miss-islington · 2022-01-23T18:42:44Z

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington · 2022-01-23T18:42:47Z

Sorry @iritkatriel, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f7955a82e36d4c32ebdd7b7707cdf0e6ffa7a418 3.10

miss-islington · 2022-01-23T18:42:50Z

Sorry, @iritkatriel, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f7955a82e36d4c32ebdd7b7707cdf0e6ffa7a418 3.9

(cherry picked from commit f7955a8)

bedevere-bot · 2022-01-23T18:48:42Z

GH-30834 is a backport of this pull request to the 3.10 branch.

(cherry picked from commit f7955a8)

bedevere-bot · 2022-01-23T18:52:54Z

GH-30835 is a backport of this pull request to the 3.9 branch.

bedevere-bot · 2022-01-23T18:54:39Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit f7955a8.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/830) and take a look at the build logs.
Check if the failure is related to this commit (f7955a8) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/830

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 36 sec
test_multiprocessing_spawn: 2 min 35 sec
test_multiprocessing_forkserver: 1 min 51 sec
test_unparse: 1 min 26 sec
test_asyncio: 1 min 20 sec
test_tokenize: 1 min 14 sec
test_nntplib: 1 min 1 sec
test_logging: 60.0 sec
test_capi: 52.9 sec
test_lib2to3: 52.8 sec

1 test altered the execution environment:
test_ftplib

17 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_ioctl
test_msilib test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 9 min 33 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_6579efa7'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1345, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_360b6c08'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception
k

bedevere-bot · 2022-01-23T19:03:03Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows Non-Debug 3.x has failed when building commit f7955a8.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/730/builds/2836) and take a look at the build logs.
Check if the failure is related to this commit (f7955a8) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/730/builds/2836

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

394 tests OK.

10 slowest tests:

test_peg_generator: 4 min 14 sec
test_multiprocessing_spawn: 1 min 57 sec
test_concurrent_futures: 1 min 34 sec
test_asyncio: 1 min 9 sec
test_socket: 1 min
test_mmap: 58.0 sec
test_distutils: 48.9 sec
test_io: 40.1 sec
test_urllib2_localnet: 38.3 sec
test_largefile: 34.6 sec

1 test altered the execution environment:
test_asyncio

37 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_idle test_ioctl
test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_nis test_openpty
test_ossaudiodev test_pipes test_poll test_posix test_pty test_pwd
test_readline test_resource test_spwd test_syslog test_tcl
test_threadsignals test_tix test_tk test_ttk_guionly
test_ttk_textonly test_turtle test_wait3 test_wait4
test_xxtestfuzz test_zipfile64

Total duration: 13 min 49 sec

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
    ^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\base_events.py", line 745, in call_soon
    self._check_closed()
    ^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\base_events.py", line 506, in _check_closed
    raise RuntimeError('Event loop is closed')
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Event loop is closed
k

…H-30834) (cherry picked from commit f7955a8)

…H-30835) (cherry picked from commit f7955a8)

) (pythonGH-30835) (cherry picked from commit f7955a8)

bpo-41403: Improve error message for invalid mock target

d7d4e0b

iritkatriel requested a review from cjw296 as a code owner January 23, 2022 17:40

cjw296 approved these changes Jan 23, 2022

View reviewed changes

bedevere-bot added the awaiting merge label Jan 23, 2022

arhadthedev reviewed Jan 23, 2022

View reviewed changes

add news

6460ea1

iritkatriel added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 23, 2022

use format string

461e59e

iritkatriel merged commit f7955a8 into python:main Jan 23, 2022

bedevere-bot removed the awaiting merge label Jan 23, 2022

miss-islington assigned iritkatriel Jan 23, 2022

iritkatriel added a commit that referenced this pull request Jan 23, 2022

bpo-41403: Improve error message for invalid mock target (GH-30833)

3596331

(cherry picked from commit f7955a8)

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 23, 2022

iritkatriel added a commit that referenced this pull request Jan 23, 2022

bpo-41403: Improve error message for invalid mock target (GH-30833)

4f13987

(cherry picked from commit f7955a8)

bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 23, 2022

iritkatriel added a commit that referenced this pull request Jan 23, 2022

bpo-41403: Improve error message for invalid mock target (GH-30833) (G…

e3ade66

…H-30834) (cherry picked from commit f7955a8)

iritkatriel added a commit that referenced this pull request Jan 23, 2022

bpo-41403: Improve error message for invalid mock target (GH-30833) (G…

1398dca

…H-30835) (cherry picked from commit f7955a8)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022

bpo-41403: Improve error message for invalid mock target (pythonGH-30833

d02666f

) (pythonGH-30835) (cherry picked from commit f7955a8)

iritkatriel deleted the bpo-41403 branch December 7, 2022 15:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-41403: Improve error message for invalid mock target #30833

bpo-41403: Improve error message for invalid mock target #30833

iritkatriel commented Jan 23, 2022 •

edited by bedevere-bot

Loading

arhadthedev Jan 23, 2022

iritkatriel Jan 23, 2022

arhadthedev Jan 23, 2022

iritkatriel Jan 23, 2022

miss-islington commented Jan 23, 2022

miss-islington commented Jan 23, 2022

miss-islington commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

		raise TypeError("Need a valid target to patch. You supplied: %r" %
		(target,))

	raise TypeError("Need a valid target to patch. You supplied: %r" %
	(target,))
	raise TypeError(f"Need a valid target to patch. You supplied: {target}")

bpo-41403: Improve error message for invalid mock target #30833

bpo-41403: Improve error message for invalid mock target #30833

Conversation

iritkatriel commented Jan 23, 2022 • edited by bedevere-bot Loading

arhadthedev Jan 23, 2022

Choose a reason for hiding this comment

iritkatriel Jan 23, 2022

Choose a reason for hiding this comment

arhadthedev Jan 23, 2022

Choose a reason for hiding this comment

iritkatriel Jan 23, 2022

Choose a reason for hiding this comment

miss-islington commented Jan 23, 2022

miss-islington commented Jan 23, 2022

miss-islington commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

bedevere-bot commented Jan 23, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Jan 23, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

iritkatriel commented Jan 23, 2022 •

edited by bedevere-bot

Loading