bpo-31221: patchcheck ignores external libraries #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
reviewed
Aug 16, 2017
Tools/scripts/patchcheck.py
Outdated
| filenames.append(filename) | ||
| return filenames | ||
| else: | ||
| if not os.path.exists(os.path.join(SRCDIR, '.git')): | ||
| sys.exit('need a Mercurial or git checkout to get modified files') |
|
Looks fine as far as I can tell; I'm not particularly familiar with patchcheck. |
brettcannon
approved these changes
Aug 16, 2017
Tools/scripts/patchcheck.py now ignores changes in directories which are copies of external libraries: * Modules/_ctypes/libffi_msvc/ * Modules/_ctypes/libffi_osx/ * Modules/_decimal/libmpdec/ * Modules/expat/ * Modules/zlib/ Drop also support for Mercurial, since CPython migrated to Git. Exclude also libmpdec patchcheck: exclude also libffi_osx and libffi_msvc
|
GH-3116 is a backport of this pull request to the 3.6 branch. |
|
GH-3118 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
changed the title
vstinner
added a commit
that referenced
this pull request
Aug 17, 2017
* bpo-31221: patchcheck ignores external libraries (#3109) Tools/scripts/patchcheck.py now ignores changes in directories which are copies of external libraries: * Modules/_ctypes/libffi_msvc/ * Modules/_ctypes/libffi_osx/ * Modules/_decimal/libmpdec/ * Modules/expat/ * Modules/zlib/ Drop also support for Mercurial, since CPython migrated to Git. Exclude also libmpdec patchcheck: exclude also libffi_osx and libffi_msvc (cherry picked from commit 4a347ce) * Exclude also Modules/_ctypes/libffi on Python 3.6
vstinner
added a commit
that referenced
this pull request
Aug 17, 2017
* bpo-31221: patchcheck ignores external libraries (#3109) Tools/scripts/patchcheck.py now ignores changes in directories which are copies of external libraries: * Modules/_ctypes/libffi_msvc/ * Modules/_ctypes/libffi_osx/ * Modules/_decimal/libmpdec/ * Modules/expat/ * Modules/zlib/ Drop also support for Mercurial, since CPython migrated to Git. Exclude also libmpdec patchcheck: exclude also libffi_osx and libffi_msvc (cherry picked from commit 4a347ce) * Exclude also Modules/_ctypes/libffi on Python 2.7 * Remove _decimal/libmpdec, not in Python 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools/scripts/patchcheck.py now ignores changes in Modules/expat/ and
Modules/zlib/ subdirectories. Drop also support for Mercurial, since
CPython migrated to Git.
https://bugs.python.org/issue31221