-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-46755: Don't log stack info twice in QueueHandler #31355
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
In your example the line
|
Actually, I am able to reproduce this. The issue had dropped off my radar, but it's back on now. |
Thanks @emontnemery for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Thanks @emontnemery for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry @emontnemery and @vsajip, I had trouble checking out the |
GH-94564 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit c60f125) Co-authored-by: Erik Montnemery <erik@montnemery.com>
(cherry picked from commit c60f125)
GH-94565 is a backport of this pull request to the 3.10 branch. |
The upstream cpython bug has been fixed python/cpython#31355
In QueueHandler in logging, the stack info (stack_info) was being appended to the message twice after bpo-31084. This clears
LogRecord.stack_info
in the QueueHandler.https://bugs.python.org/issue46755