Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46755: Don't log stack info twice in QueueHandler #31355

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Feb 15, 2022

In QueueHandler in logging, the stack info (stack_info) was being appended to the message twice after bpo-31084. This clears LogRecord.stack_info in the QueueHandler.

https://bugs.python.org/issue46755

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@emontnemery

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 3, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@MaxwellDupre
Copy link
Contributor

In your example the line

_LOGGER.error("Hello", stack_info=True)
Produces an error that says not found in latest version 3.12.
Also, tried a few examples using exc_info=True but could not find any issues.
Do you have an example that shows this issue?

@vsajip
Copy link
Member

vsajip commented Jul 5, 2022

Actually, I am able to reproduce this. The issue had dropped off my radar, but it's back on now.

@vsajip vsajip merged commit c60f125 into python:main Jul 5, 2022
@vsajip vsajip added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 5, 2022
@miss-islington
Copy link
Contributor

Thanks @emontnemery for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @emontnemery for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @emontnemery and @vsajip, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c60f125533b8808317c1370450f0535430d59d8c 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 5, 2022
@bedevere-bot
Copy link

GH-94564 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
(cherry picked from commit c60f125)

Co-authored-by: Erik Montnemery <erik@montnemery.com>
vsajip pushed a commit to vsajip/cpython that referenced this pull request Jul 5, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 5, 2022
@bedevere-bot
Copy link

GH-94565 is a backport of this pull request to the 3.10 branch.

vsajip pushed a commit that referenced this pull request Jul 5, 2022
… (GH-94564)

Co-authored-by: Erik Montnemery <erik@montnemery.com>
vsajip added a commit that referenced this pull request Jul 5, 2022
… (GH-94565)

Co-authored-by: Erik Montnemery <erik@montnemery.com>
bdraco added a commit to home-assistant/core that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants