Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module #31683

Merged
merged 1 commit into from
Mar 4, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module #31683

merged 1 commit into from
Mar 4, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 4, 2022 •
edited
Loading

@kumaraditya303
Copy link
Contributor

Wrong bpo number ?

erlend-aasland
erlend-aasland approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check bpo number; else looks good to me.

kumaraditya303
kumaraditya303 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 changed the title bpo-46430: Remove usage of _Py_IDENTIFIER from lzma module bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module Mar 4, 2022
@corona10
Copy link
Member Author

corona10 commented Mar 4, 2022

I will merge this PR once the adding label is available, it looks like the outage situation.

ericsnowcurrently
ericsnowcurrently approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit d168c72 into python:main Mar 4, 2022
@corona10 corona10 deleted the bpo-46430-lzma branch March 4, 2022 16:38
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @kumaraditya303 @ericsnowcurrently @erlend-aasland @the-knights-who-say-ni @bedevere-bot