Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31358: Pull zlib out of the repository #3375

Merged
merged 3 commits into from
Sep 7, 2017
Merged

bpo-31358: Pull zlib out of the repository #3375

merged 3 commits into from
Sep 7, 2017

Conversation

zware
Copy link
Member

@zware zware commented Sep 6, 2017 •
edited by bedevere-bot
Loading

@zware zware requested a review from a team as a code owner September 6, 2017 00:51
zooba
zooba approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though you seem to be on a slightly out of date master, so you may want to merge and rebuild first (should use PlatformToolset v141)

@zware
Copy link
Member Author

zware commented Sep 6, 2017

That ought to merge away; I'll poke AppVeyor to give it a fresh test just to be sure.

@zware zware merged commit d01db1c into python:master Sep 7, 2017
@zware zware deleted the extract_zlib branch September 7, 2017 00:29
@viktorkholod viktorkholod mentioned this pull request Nov 5, 2018
Closed
@hugovk hugovk mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zware @zooba @Mariatta @the-knights-who-say-ni @bedevere-bot