Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) #3548

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 13, 2017

(cherry picked from commit a5b4ea1)

https://bugs.python.org/issue31271

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@vstinner
Copy link
Member

Test failed:

======================================================================

FAIL: test_illegal_encoder (test.test_io.CTextIOWrapperTest)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_io.py", line 2675, in test_illegal_encoder

    self.assertRaises(TypeError, t.write, 'bar')

AssertionError: TypeError not raised

======================================================================

FAIL: test_illegal_encoder (test.test_io.PyTextIOWrapperTest)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_io.py", line 2675, in test_illegal_encoder

    self.assertRaises(TypeError, t.write, 'bar')

AssertionError: TypeError not raised

@Mariatta
Copy link
Member

Thanks @Haypo. Does @orenmn (who made the PR) or @serhiy-storchaka (who merged the PR) want to prepare the backport PR?

I also opened python/miss-islington#26 for some ideas of what @miss-islington can do in the future to handle this situation.

@Mariatta Mariatta closed this Sep 16, 2017
@miss-islington miss-islington deleted the backport-a5b4ea1-2.7 branch September 16, 2017 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants