Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-68272: add sub-millisecond display in pstats #3931

Closed
wants to merge 3 commits into from

Conversation

romuald
Copy link
Contributor

@romuald romuald commented Oct 9, 2017

When running pstats with functions that take less than 0.5 millisecond
(per call for example), the value shown is '0.000, which isn't really
helpful.

This patch aims to show the value in microseconds instead of seconds for
values that would otherwise be displayed as '0.000'

https://bugs.python.org/issue24084

When running pstats with functions that take less than 0.5 millisecond
(per call for example), the value shown is '0.000, which isn't really
helpful.

This patch aims to show the value in microseconds instead of seconds for
values that would otherwise be displayed as '0.000'
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@romuald
Copy link
Contributor Author

romuald commented Oct 9, 2017

(Note that I have only tested this patch against the 3.6 branch, as I can't currently compile the master branch on my development machine)

@romuald
Copy link
Contributor Author

romuald commented Oct 9, 2017

(added my github account to my bpo account just now)

@guillochon
Copy link

Any update here? Would make pstats a bit more useful...

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 25, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jul 24, 2022

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 7, 2022
@arhadthedev arhadthedev changed the title bpo-24084: add sub-millisecond display in pstats gh-68272: add sub-millisecond display in pstats Feb 14, 2023
@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Feb 14, 2023
@romuald romuald mannequin mentioned this pull request Feb 14, 2023
@arhadthedev
Copy link
Member

Closing as per #68272 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time. stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants